Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't panic at an unexpected log type #360

Merged
merged 1 commit into from Oct 22, 2021

Conversation

Vladimir-Rom
Copy link

sometimes docker returns logType = 3 which is an undocumented log type, so treat it as stdout

fix #359

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #360 (7184053) into master (31fb76b) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   62.12%   61.85%   -0.27%     
==========================================
  Files          15       15              
  Lines         998     1012      +14     
==========================================
+ Hits          620      626       +6     
- Misses        283      289       +6     
- Partials       95       97       +2     
Impacted Files Coverage Δ
docker.go 64.58% <0.00%> (-0.66%) ⬇️
container.go 85.29% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fb76b...7184053. Read the comment docs.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vladimir-Rom thanks for this contribution. It seems OK to me although, as as you said, it could be difficult to reproduce it.

Nevertheless, I'm not blocking it, so LGTM 👍

@gianarb gianarb merged commit 12cc965 into testcontainers:master Oct 22, 2021
@gianarb gianarb added the chore Changes that do not impact the existing functionality label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: received invalid log type: 3
3 participants