Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close docker provider client on container terminate #358

Merged
merged 1 commit into from Oct 22, 2021

Conversation

anjmao
Copy link

@anjmao anjmao commented Oct 1, 2021

If provider client is not closed it leaks goroutines.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and thanks for your contribution!

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #358 (2d2a7cf) into master (a8ca295) will increase coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   61.91%   62.19%   +0.27%     
==========================================
  Files          15       15              
  Lines        1011     1013       +2     
==========================================
+ Hits          626      630       +4     
+ Misses        288      286       -2     
  Partials       97       97              
Impacted Files Coverage Δ
docker.go 65.28% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a9803...2d2a7cf. Read the comment docs.

@anjmao
Copy link
Author

anjmao commented Oct 1, 2021

@mdelapenya I'm not sure about coverage report failure. It says that my changed was not covered by tests, but there are many tests which calls Terminate method.

@mdelapenya
Copy link
Collaborator

@mdelapenya I'm not sure about coverage report failure. It says that my changed was not covered by tests, but there are many tests which calls Terminate method.

... but probably not entering the if err != nil block. So I guess the CI build did not cause the Docker client to fail while closing :)

@gianarb gianarb merged commit 5c5c627 into testcontainers:master Oct 22, 2021
@gianarb
Copy link
Collaborator

gianarb commented Oct 22, 2021

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants