Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container examples to documentation, clean up README #353

Merged
merged 14 commits into from Oct 22, 2021
Merged

Add container examples to documentation, clean up README #353

merged 14 commits into from Oct 22, 2021

Conversation

jaredpetersen
Copy link
Contributor

@jaredpetersen jaredpetersen commented Sep 11, 2021

This is a multipart documentation update.

I added code samples for how to use Testcontainers-Go with CockroachDB, Redis, and NGINX per the discussion in #112 and #351. I've run all of the example code to make sure that everything completes as expected.

I know there are more examples from past closed PRs for things like Minio, MongoDB, and Postgres that the old canned modules documentation referenced. However, since canned modules are now a dead concept, sharing that code won't be very helpful and it needs some tweaking in order to fit into this new example-based documentation model. I'd like to contribute Postgres, MySQL, and Kafka + Schema Registry examples too but I'll need more time for those. This is a good starting point though and we can begin helping people now rather than later.

I also updated the README a bit so that it uses language from more of a project perspective rather than an individual author perspective per #351. I also found that the existing NGINX example no longer compiles because it referenced a no longer existing Terminate(ctx context.Context, t *testing.T) function.

The project description on GitHub has a grammatical issue that should be fixed. The word "provides" should be used instead of "providing":

...Golang library that providing a friendly API...

However, I would instead suggest replacing the project description entirely with the following:

Testcontainers-Go is a Go package that makes it simple to create and clean up containers for automated tests

It just needs to be small, quick hook rather than a two sentence summary 🙂

@jaredpetersen jaredpetersen marked this pull request as ready for review September 11, 2021 06:08
@jaredpetersen
Copy link
Contributor Author

CC @mdelapenya since we last talked about docs in one of the linked issues. No rush here necessarily though.

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #353 (429451f) into master (a8ca295) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   61.91%   61.91%           
=======================================
  Files          15       15           
  Lines        1011     1011           
=======================================
  Hits          626      626           
  Misses        288      288           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a9803...429451f. Read the comment docs.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jaredpetersen this LGTM, although there are conflicts in the modules section (a PR was merged with kafka canned container). Could you please resolve them? I will approve these changes right after, as I see them as a great improvement for the project. Great job with the clean-up!!

docs/features/garbage_collector.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
@jaredpetersen
Copy link
Contributor Author

I'll get on that conflict ASAP. Thanks for reviewing 👍

@jaredpetersen
Copy link
Contributor Author

jaredpetersen commented Oct 3, 2021

Fixed those conflicts, ready for review again.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay 🙏 AND this LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants