fix: cache http wait request body #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See testcontainers#338 Closes testcontainers#338 Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
mdelapenya
reviewed
Aug 4, 2021
There was a problem hiding this comment.
@ajcasagrande thanks for taking your time to fix this, and the explanation on how to reproduce it.
I added a comment about the usage of a method that is failing in the test execution for Go 1.14.
Other than that, LGTM!
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
|
Unit tests are failing due to #341. For now I have pinned the version of rabbitmq to |
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 60.91% 61.41% +0.50%
==========================================
Files 15 15
Lines 985 990 +5
==========================================
+ Hits 600 608 +8
+ Misses 293 290 -3
Partials 92 92
Continue to review full report at Codecov.
|
mdelapenya
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated the test code to check for this specific issue. If you run the updated tests against the current
masterit will fail due to the bug that this addresses.Closes #338
Closes #341