Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store raw information of a container #334

Merged
merged 2 commits into from Jul 21, 2021

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

It stores raw information of a container (JSON format) in the Docker Container struct

Why is it important?

Caused by #271, where we are getting the state of a container from the Docker client, but we did not add the field

@mdelapenya mdelapenya requested a review from gianarb July 21, 2021 10:13
@mdelapenya mdelapenya self-assigned this Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #334 (3f7261c) into master (066c492) will decrease coverage by 2.92%.
The diff coverage is 44.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   64.04%   61.11%   -2.93%     
==========================================
  Files          13       15       +2     
  Lines         865      985     +120     
==========================================
+ Hits          554      602      +48     
- Misses        226      291      +65     
- Partials       85       92       +7     
Impacted Files Coverage Δ
wait/health.go 0.00% <0.00%> (ø)
wait/sql.go 0.00% <0.00%> (ø)
wait/wait.go 100.00% <ø> (ø)
wait/http.go 56.04% <28.57%> (-1.43%) ⬇️
wait/host_port.go 56.14% <30.76%> (-4.28%) ⬇️
wait/exit.go 48.00% <48.00%> (ø)
docker.go 63.99% <51.72%> (-1.84%) ⬇️
compose.go 74.04% <75.75%> (+0.57%) ⬆️
container.go 85.29% <100.00%> (+0.91%) ⬆️
wait/log.go 75.75% <100.00%> (-2.03%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0479536...3f7261c. Read the comment docs.

@gianarb
Copy link
Collaborator

gianarb commented Jul 21, 2021

Thanks a lot

@gianarb gianarb merged commit dfc50d7 into testcontainers:master Jul 21, 2021
@mdelapenya mdelapenya deleted the store-raw branch July 26, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants