Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Use default docker host detection chain to auto-detect Podman #2503

Open
p-jahn opened this issue Apr 19, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@p-jahn
Copy link
Contributor

p-jahn commented Apr 19, 2024

Proposal

The Podman detection relies on DOCKER_HOST but the env var might not always be set. For example, on macOS, there is a helper that symlinks /var/run/docker.sock to the Podman socket so setting DOCKER_HOST is not necessary.

To be more reliable the detection heuristic should lean on the default host detection, which also checks the testcontainer config and even could be extended to resolve the symlinked socket location to detect the use of Podman.

I already played around with these ideas and am happy to provide a PR if you also think this makes sense.

Related: #2264

@p-jahn p-jahn added the enhancement New feature or request label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant