fix: timeout and shutdown #121
Merged
+33
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix waitForPruneCondition timeout handling which was not resetting the connection timeout when new connections came in resulting in the reaper shutting down incorrectly. Don't log EOF errors. Add buffer to connection channels so we don't block the accepting goroutine. Fixes testcontainers/testcontainers-go#2348
|
@mdelapenya any chance you can help get this one across the line, as its causing random failures in testcontainers-go? |
mdelapenya
approved these changes
Apr 8, 2024
Thanks for that, most appreciated! To get this one fully put to bed, what's the release process, as we'll need to a PR against testcontainers-go to bump it to the new version to get this fix? |
|
Exactly, I'm planning to create a release of Ryuk soon this week, the 0.7.1 |
|
Just checking in on the release @mdelapenya to make sure it doesn't slip though 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
waitForPruneConditiontimeout handling which was not resetting the connection timeout when new connections came in resulting in the reaper shutting down incorrectly.Don't log
EOFerrors.Add buffer to connection channels so we don't block the accepting goroutine.
Fixes testcontainers/testcontainers-go#2348