feat(modules.mongodb): add replica set support via opts #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Some differences between this PR and #2139 include:
|
heiytor
force-pushed
the
feat/mongodb-replica-set
branch
2 times, most recently
from
504cd35
to
4e6248c
Compare
mdelapenya
reviewed
May 8, 2024
mdelapenya
reviewed
May 8, 2024
heiytor
force-pushed
the
feat/mongodb-replica-set
branch
from
4e6248c
to
fa37148
Compare
The `WithReplicaSet` option configures the MongoDB container to run a single-node replica set named "rs". The container will wait until the replica set is ready.
heiytor
force-pushed
the
feat/mongodb-replica-set
branch
from
fa37148
to
e6bc11e
Compare
mdelapenya
approved these changes
May 8, 2024
| @@ -58,6 +58,12 @@ It is used in conjunction with `WithUsername` to set a username and its password | |||
|
|
|||
| E.g. `testcontainers.WithPassword("mymongopwd")`. | |||
|
|
|||
| #### WithReplicaSet | |||
There was a problem hiding this comment.
@heiytor I went ahead and added the docs for the new option: https://deploy-preview-2469--testcontainers-go.netlify.app/modules/mongodb/#withreplicaset
Once the CI passes, I'll merge this one, thanks!
mdelapenya
added
the
feature
mdelapenya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implementing a
WithReplicaSetfunction to configure the container to run with a default single-node replica set named "rs". This function appends "--replSet rs" toreq.Cmdto initialize MongoDB in preparation to receive a replica set. Additionally, after execution, it initializes the replica set using "rs.initiate()", configuring the current host as the PRIMARY.Why is it important?
I've been utilizing testcontainers to test my service environment, which necessitates a replica set to execute transactions. As I've developed this functionality for internal use, I believe it would be beneficial to others as well.
Related issues
This PR closes #2138. Additionally, I noticed that there is another PR, #2139, which also aims to implement this feature. However, it has not been updated for a while, and this branch has certain differences, such as utilizing both
mongoshandmongoto ensure version compatibility.How to test this PR
I've tested this in a production environment, so it should work fine. Additionally, I've added new test cases to
TestMongoDB.Follow-ups
Maybe adding a sharding option would be great.