Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canned etcd #101

Closed
gianarb opened this issue Oct 4, 2019 · 3 comments · Fixed by #268
Closed

canned etcd #101

gianarb opened this issue Oct 4, 2019 · 3 comments · Fixed by #268
Labels
feature New functionality or new behaviors on the existing one

Comments

@gianarb
Copy link
Collaborator

gianarb commented Oct 4, 2019

Lisa from Influx wrote this etcd container request for one of our tests. Probably we can make it to be a canned container as well.

	reqEtcd := ContainerRequest{
		Image: "quay.io/coreos/etcd:v3.2",
		WaitingFor: wait.ForAll(
			wait.ForLog("listening for client requests on 0.0.0.0:2379"),
		),
		ExposedPorts: []string{"2379/tcp", "4001/tcp"},
		SkipReaper:   true,
	}
@gianarb gianarb added the feature New functionality or new behaviors on the existing one label Oct 4, 2019
@achew22
Copy link

achew22 commented Oct 4, 2019

Has there been any consideration of creating a text format that could be shared among the various testcontainers projects rather than having a disparate set for each library?

@mdelapenya
Copy link
Collaborator

We started this PR, which could be the seed for modules: #618

It creates examples to be consumed by the website, but turning them into modules would be a matter of adjusting the templates.

@mdelapenya
Copy link
Collaborator

Given #618 has been merged, we created #636, where you can find how to contribute new modules :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants