Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Refactor the IImage properties (align with DSL) #740

Open
HofmeisterAn opened this issue Jan 19, 2023 · 3 comments · May be fixed by #962
Open

[Enhancement]: Refactor the IImage properties (align with DSL) #740

HofmeisterAn opened this issue Jan 19, 2023 · 3 comments · May be fixed by #962
Labels
enhancement New feature or request

Comments

@HofmeisterAn
Copy link
Collaborator

HofmeisterAn commented Jan 19, 2023 •
edited

Problem

The IImage interface does not follow the correct naming conventions.

Solution

The interface should use the following properties: Registry, Repository, Tag, FullName.

Benefit

Align with the DSL.

Alternatives

-

Would you like to help contributing this enhancement?

Yes
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Jan 19, 2023
@HofmeisterAn HofmeisterAn mentioned this issue Jan 19, 2023
Merged
@jacobjmarks
Copy link
Contributor

Has this been resolved with #729?

@HofmeisterAn
Copy link
Collaborator Author

HofmeisterAn commented Jul 28, 2023 •
edited

No, it is something we still need to change. I have not touched it because it introduces breaking changes. To align with the Docker DSL we need to rename (adjust) the properties, e.g.

Actual Expected
Registry - myregistryhost:5000
Repository myregistryhost:5000/fedora fedora/httpd
Name httpd -
Tag version1.0 version1.0
GetHostname() myregistryhost:5000 -

@jacobjmarks
Copy link
Contributor

Happy to work on this if it's something you'd like to see done, despite the breaking changes.

@jacobjmarks jacobjmarks linked a pull request Jul 29, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Refactor IImage properties to align with DSL jacobjmarks/testcontainers-dotnet
2 participants
@HofmeisterAn @jacobjmarks