Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add Qdrant test container #992

Open
russcam opened this issue Sep 6, 2023 · 2 comments · May be fixed by #1149
Open

[Feature]: Add Qdrant test container #992

russcam opened this issue Sep 6, 2023 · 2 comments · May be fixed by #1149
Assignees
@HofmeisterAn
Labels
enhancement New feature or request module An official Testcontainers module

Comments

@russcam
Copy link

russcam commented Sep 6, 2023

Problem

Qdrant is a vector search engine/database that is becoming popular for search and recommendations use cases. Qdrant provides docker images but there isn't currently an official .NET test container. This issue proposes adding one.

Solution

Open a PR with Qdrant test container from https://github.com/russcam/qdrant-dotnet-client/tree/main/tests/Qdrant.Grpc.Tests/Container

Benefit

Provides a qdrant test container for folks that need it

Alternatives

Folks who need a qdrant test container each define it themselves

Would you like to help contributing this enhancement?

Yes
@russcam russcam added the enhancement New feature or request label Sep 6, 2023
@russcam russcam changed the title [Enhancement]: Add Qdrant test container [Feature]: Add Qdrant test container Sep 6, 2023
@HofmeisterAn
Copy link
Collaborator

Thank you for bringing up this issue. Since you've already made progress on an implementation, I'm happy to review the pull request as soon as you're ready. I believe we briefly discussed the client implementation, right? There is no official .NET client, right? If not, how can we test the module? Can we utilize e.g. a generic HTTP request?

@HofmeisterAn HofmeisterAn self-assigned this Sep 7, 2023
russcam added a commit to russcam/testcontainers-dotnet that referenced this issue Sep 10, 2023
@russcam
Add Qdrant container
75528e0 
This commit adds a qdrant container to the list of supported
Testcontainers.

The qdrant container allows configuration of:

- an API key to authenticate to Qdrant
- an x509 certificate used to secure communication to Qdrant with
  Transport Layer Security
- a custom configuration file. See
  https://qdrant.tech/documentation/guides/configuration/

Closes testcontainers#992
@russcam russcam mentioned this issue Sep 10, 2023
Closed
@russcam
Copy link
Author

russcam commented Sep 10, 2023

Opened #994.

There is currently no official client; qdrant exposes both HTTP and gRPC APIs, so the HTTP API can be tested with HttpClient. The gRPC API can be tested with https://www.nuget.org/packages/Qdrant.Grpc for the time being, if need be.

@eddumelendez eddumelendez mentioned this issue Feb 20, 2024
Closed
@HofmeisterAn HofmeisterAn added the module An official Testcontainers module label Mar 11, 2024
@eerhardt eerhardt mentioned this issue Mar 29, 2024
Merged
russcam added a commit to russcam/testcontainers-dotnet that referenced this issue Mar 30, 2024
@russcam
Add Qdrant container
6b6d3fc 
This commit adds a qdrant container to the list of supported
Testcontainers.

The qdrant container allows configuration of:

- an API key to authenticate to Qdrant
- an x509 certificate used to secure communication to Qdrant with
  Transport Layer Security
- a custom configuration file. See
  https://qdrant.tech/documentation/guides/configuration/

Closes testcontainers#992
@russcam russcam linked a pull request Apr 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HofmeisterAn HofmeisterAn

Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Milestone
No milestone
2 participants
@russcam @HofmeisterAn