fix: fix incorrect node engine semver versions #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this shows error terser@5.3.6: The engine "node" is incompatible with this module. Expected version "^10.0.0,^11.0.0,^12.0.0,>=14.0.0". Got "12.18.4"
artsiomr
approved these changes
Oct 19, 2020
|
I think the review is approved. Can someone merge this PR. |
Closed
|
This also seems to fix #856 and #858 Tagging @fabiosantoscode @alexlamsl since they might not get notified about the PR since they're not assigned |
kytta
approved these changes
Oct 19, 2020
s-dupuis
approved these changes
Oct 19, 2020
PhilippMeissner
approved these changes
Oct 19, 2020
dumavit
approved these changes
Oct 19, 2020
|
please merge |
melnikovic
approved these changes
Oct 19, 2020
|
Hello there! Thank you, let's get this released! |
|
This is a good explanation: #857 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this shows error terser@5.3.6: The engine "node" is incompatible with this module. Expected version "^10.0.0,^11.0.0,^12.0.0,>=14.0.0". Got "12.18.4"
Closes: #854