Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #1124
I fix this issue by adding a context to determine if the current expression is under the class field. if is true, then it is legal to use an
in
operator withprivatename
token. if is false. parse would throw an error.And I find a problem is that terser allow
parse
function to accept private field even out of class field, which should be a syntax error. so I add a condition tosubscripts
function to determine if the current subscript is under class feild. if is true, parse would parse it correctly, if is false it would throw an error.To pass the test, I delete one test from
/compress/class-properity
which allowsparse
function to accept private fields even out of class field, which should be a syntax error.I also add a condition to binary expression, because even class field can use in operation with privatename, other expressions like add can’t use privatename without subscript. for example :