Fix compress/eval of optional chains #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiosantoscode
requested changes
Sep 11, 2021
This implements the recursion necessary to determine if a property access/call is part of an optional chain that has short-circuited.
Co-authored-by: Fábio Santos <fabiosantosart@gmail.com>
jridgewell
force-pushed
the
optional-chain
branch
from
841d0ce
to
7a9e6e4
Compare
jridgewell
force-pushed
the
optional-chain
branch
from
7a9e6e4
to
f76cdb6
Compare
lib/compress/index.js
Outdated
| @@ -2436,7 +2432,7 @@ def_optimize(AST_Call, function(self, compressor) { | |||
| } | |||
|
|
|||
| var ev = self.evaluate(compressor); | |||
| if (ev !== self) { | |||
| if (ev !== self && ev !== nullish) { | |||
There was a problem hiding this comment.
We can remove these checks, by making evaluate return this when it sees nullish.
There's already a bit of a redirection, so it's probably good to take advantage of it.
There was a problem hiding this comment.
For some reason, the link doesn't show me where you're pointing. I'm assuming it's the AST_Node.DEFMETHOD("evaluate", …) definition, so I added a check there.
|
I asked for just one more little change. This is otherwise looking great, love those tests! |
|
This is great, thank you 💪 Will release on Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the recursion necessary to determine if a property access/call is part of an optional chain that has short-circuited.
Fixes #1040