Fix private getter/setter mangling #1060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error with private getter/setters being mangled as if they were regular public properties:
In this,
get #aaaaaa {}
is aAST_PrivateGetter
, which isn't a subclass ofAST_ClassPrivateProperty
norAST_PrivateMethod
. But it is a subclass ofAST_ObjectProperty
. So our property mangler was mangling the key as if it were a public property, and not consulting theprivate_cache
mapping. So the mangler renames the getter to#o
and the access to#a
:This also enables private property mangling by default whenever we're doing a normal mangle pass. This is as safe as mangling regular
const variable_name = 1
, because private properties are completely analyzable in the lexical scope.Re: #1012