Fix nullish coalescing negation inference #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does 2 things: - It removes special casing for nullish coalescing (??) in negation - This fixes terser#1003 - We also made sure optional chaining (?.) is ok - This cements terser#1007 as fixed
|
Great PR, thanks! |
10 tasks
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 4, 2022
Bumping Terser from v5.7.1 to v5.10.0 fixes some minification issues: - I specifically encountered this bug, where a boolean condition was flipped when a nullish coalescing operator was involved: terser/terser#1045 - See [Terser's changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) for more fixes ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
Bumping Terser from v5.7.1 to v5.10.0 fixes some minification issues: - I specifically encountered this bug, where a boolean condition was flipped when a nullish coalescing operator was involved: terser/terser#1045 - See [Terser's changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) for more fixes ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things: