Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Scripts minfiier has cloned variable names that crashes program when mange is activated #173

Open
Mrgaton opened this issue Nov 24, 2023 · 3 comments

Comments

@Mrgaton
Copy link

Mrgaton commented Nov 24, 2023

What happened?

i have two diferent scripts that defines diferent const and two of them defines them witht he same variable name and enter in conflict

Version

latest

What browsers are you seeing the problem on?

Firefox, Chrome, Safari

Link to reproduce

https://genocidioastral.fundacionamigos.repl.co/Pages/doxeo.html

Relevant log output

Warning to the link is a meme page that gravs your ip and makes it dance like you got hacked i know very bruh but xd

Willing to submit a PR?

None

@Mrgaton
Copy link
Author

Mrgaton commented Nov 24, 2023

it only happends when you have

minifyJS: { toplevel: true},

@Mrgaton
Copy link
Author

Mrgaton commented Nov 24, 2023

teaser would have to have the context of all the scripts at the same time so that even with the top level activated it does not define variables with the same name over and over again

@Mrgaton
Copy link
Author

Mrgaton commented Nov 24, 2023

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant