Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bidirectional connection animation in sketch mode #1943

Closed
danielsuh05 opened this issue May 19, 2024 · 2 comments
Closed

bidirectional connection animation in sketch mode #1943

danielsuh05 opened this issue May 19, 2024 · 2 comments

Comments

@danielsuh05
Copy link
Contributor

In sketch mode, bidirectional connection animations are still animated only in one direction. This was resolved in normal mode in issue #1936, but the issue still exists in sketch mode.

Video:

Screen.Recording.2024-05-19.at.15.18.07.mov
@danielsuh05
Copy link
Contributor Author

Can we just convert sketch paths into normal paths? I know you mentioned it here (#655) and it would be trivial to just export the code from d2svg.go and share it with d2sketch.go. I can't think of any easier way other than re-writing the sketch path code for animations.

@alixander
Copy link
Collaborator

I'd accept that solution. I don't think it visually loses much at all to convert animated sketch paths be normal paths. But I do want to keep non-animated sketch paths the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants