Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining circle shape for arrowheads with sketch mode removes all arrowheads #1937

Open
ddolan-lutron opened this issue May 10, 2024 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ddolan-lutron
Copy link

See this playground.

Setting the arrowhead shape for either source or target arrowheads to circle causes all arrowheads to be omitted from the diagram when Sketch Mode is used. Seems to be independent of other arrowhead properties.

@alixander alixander added bug Something isn't working good first issue Good for newcomers labels May 10, 2024
@sossost
Copy link

sossost commented May 11, 2024

Hi! @alixander I am sossost, a new contributor. I would like to solve this issue. Could you assign it for me?

@alixander
Copy link
Collaborator

Much appreciated @sossost !

See relevant starting tip here: #1936 (comment)

@sossost
Copy link

sossost commented May 16, 2024

@alixander
hello. I tried this issue because it seemed interesting, but it was too difficult due to my lack of understanding of the Go language. Can I give someone else a chance?? sorry.

@alixander
Copy link
Collaborator

No worries @sossost , thanks for trying!

@bo-ku-ra
Copy link
Contributor

maybe i'm looking in the wrong place, but...

sketch.go (func ArrowheadJS)
case d2target.CircleArrowhead:
and
case d2target.FilledCircleArrowhead:
are missing?

@danielsuh05
Copy link
Contributor

I'd like to take this issue if possible, I feel pretty comfortable in the D2 repo now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

5 participants