Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate __ALL__, use __all__ instead #23

Merged
merged 3 commits into from Sep 25, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 23, 2022

Re: hfeeki/termcolor#3

__ALL__ should be lowercase: https://docs.python.org/3/tutorial/modules.html#importing-from-a-package

Let's deprecate the old one and remove it in the next major bump.

An up-to-date __all__ is in __init__.py


Also convert a % formatting to f-string, and add module docstring.

@hugovk hugovk added the changelog: Deprecated For soon-to-be removed features label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e8b320f) compared to base (81b6ed5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           69        77    +8     
=========================================
+ Hits            69        77    +8     
Flag Coverage Δ
macos-latest 100.00% <100.00%> (ø)
ubuntu-latest 100.00% <100.00%> (ø)
windows-latest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/termcolor/__init__.py 100.00% <ø> (ø)
src/termcolor/termcolor.py 100.00% <100.00%> (ø)
tests/test_termcolor.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hugovk hugovk merged commit bdbdd71 into termcolor:main Sep 25, 2022
@hugovk hugovk deleted the deprecate-__ALL__ branch September 25, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Deprecated For soon-to-be removed features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant