Build tfjs-node node addon with the release docker #6925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build the tfjs-node and tfjs-node-gpu node addons with the release docker image when publishing them to npm. This ensures a consistent GLIBCXX version is used when publishing.
mattsoulanille
force-pushed
the
tfjs_node_docker
branch
from
87ac6a3
to
a303e5e
Compare
Linchenn
approved these changes
Oct 11, 2022
pyu10055
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the tfjs-node and tfjs-node-gpu node addons with the release docker image when publishing them to npm. This ensures a consistent GLIBCXX version is used when publishing.
objdump -T lib/napi-v8/tfjs_binding.node | grep GLIBCXXBefore:
After:
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is