Use config=v1 as this is r1.15 branch.
#36190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, by default we were building V2 code on a v1 version.
gunan
approved these changes
Jan 24, 2020
|
I want to link it to issue #36179 for history. btw, I found that 1.15.1 is ~5% slower than 1.12. I benchmarked resnet50_kears and simple tensorflow-addition. Just in case I missed something, is it expected or this is regression to fix? Not sure if I have resources to debug it but maybe I could compare with v2 after upgrade. |
|
There is a large difference between 1.12 and 1.15.1. A better comparison would be between 1.15.0 and 1.15.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, by default we were building V2 code on a v1 version.