[Intel Mkl] Upgrading MKL-DNN to 0.20.6 to fix SGEMM regression #33213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penpornk
reviewed
Oct 10, 2019
There was a problem hiding this comment.
Thank you very much @claynerobison! The changes look good to me. I'll defer to the TF1.15 owners for approval decision.
|
Since there are other issues with .18, this looks good to me, as long as
we're sure this fixes the regression.
|
goldiegadde
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to r1.15 is an alternative to reverting mkl-dnn to v0.18. It fixes SGEMM regressions as well as issues that were originally fixed by the mkl-dnn upgrade to 0.20.3 (see #31910 and https://github.com/intel/mkl-dnn/releases/tag/v0.20.6). @martinwicke, @penpornk, @goldiegadde Can you verify whether this fixes the issues for you?