Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --incompatible_remove_native_http_archive=false to windows bazel calls #27870

Merged
merged 3 commits into from Apr 15, 2019

Conversation

mihaimaruseac
Copy link
Collaborator

First two commits are to remove debug stuff I just now I realized I missed on #27801 Let me know if you'd rather have them on a different PR instead.

The last one is the reason for this PR: after updating bazel to 0.20.0 to make windows GPU display messages we need this flag otherwise we get

Loading: 0 packages loaded
ERROR: error loading package '': Encountered error while reading extension file 'closure/defs.bzl': no such package '@io_bazel_rules_closure//closure': The native http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.
Use --incompatible_remove_native_http_archive=false to temporarily continue using the native rule.
ERROR: error loading package '': Encountered error while reading extension file 'closure/defs.bzl': no such package '@io_bazel_rules_closure//closure': The native http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.
Use --incompatible_remove_native_http_archive=false to temporarily continue using the native rule.

@yifeif yifeif merged commit 446d393 into r1.12 Apr 15, 2019
@mihaimaruseac mihaimaruseac deleted the bazel-http-archive branch April 15, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants