Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to run selection to hint about double click. #5842

Merged
merged 1 commit into from Aug 5, 2022

Conversation

bmd3k
Copy link
Contributor

@bmd3k bmd3k commented Aug 4, 2022

We recently added the ability to double click a run checkbox to select it only and deselect the other runs.

User feedback (googlers, see b/238365158#comment9) said it was not discoverable.

This change adds a tooltip to the checkbox, which includes a hint about double click.

image

I use "title" instead of "matTooltip" just because we have many icon buttons that also use this and the behavior is more consistent with those buttons.

@bmd3k bmd3k requested a review from japie1235813 August 4, 2022 17:43
@bmd3k bmd3k merged commit 402ee0f into tensorflow:master Aug 5, 2022
yatbear pushed a commit that referenced this pull request Aug 5, 2022
We recently added the ability to double click a run checkbox to select it only and deselect the other runs.

User feedback (googlers, see b/238365158#comment9) said it was not discoverable. 

This change adds a tooltip to the checkbox, which includes a hint about double click. I use "title" instead of "matTooltip" just because we have many icon buttons that also use this and the behavior is more consistent with those buttons.
yatbear pushed a commit to yatbear/tensorboard that referenced this pull request Mar 27, 2023
…5842)

We recently added the ability to double click a run checkbox to select it only and deselect the other runs.

User feedback (googlers, see b/238365158#comment9) said it was not discoverable. 

This change adds a tooltip to the checkbox, which includes a hint about double click. I use "title" instead of "matTooltip" just because we have many icon buttons that also use this and the behavior is more consistent with those buttons.
dna2github pushed a commit to dna2fork/tensorboard that referenced this pull request May 1, 2023
…5842)

We recently added the ability to double click a run checkbox to select it only and deselect the other runs.

User feedback (googlers, see b/238365158#comment9) said it was not discoverable. 

This change adds a tooltip to the checkbox, which includes a hint about double click. I use "title" instead of "matTooltip" just because we have many icon buttons that also use this and the behavior is more consistent with those buttons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants