core: add --detect_file_replacement flag and plumbing (redo) #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatbear
approved these changes
Feb 1, 2022
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…low#5546) * core: add --detect_file_replacement flag and plumbing * core_plugin_test.py: add load_fast * ignore unrecognized accumulator kwargs in multiplexer test * data_ingester_test.py add detect_file_replacement flag
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…low#5546) * core: add --detect_file_replacement flag and plumbing * core_plugin_test.py: add load_fast * ignore unrecognized accumulator kwargs in multiplexer test * data_ingester_test.py add detect_file_replacement flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-do of #5530, which I accidentally merged into the wrong branch (the temporary one I was using as a diffbase, rather than the intended destination of
master).Add the
--detect_file_replacementflag to control the behavior introduced in #5529, and all the associated plumbing in between.Note: since this flag would currently be pointless for RustBoard (
--load_fast=true) we disallow the combination, and in the default automatic selection logic (--load_fast=auto), we check for this flag and don't use RustBoard if it was passed.Tested: ran TensorBoard with these changes enabled (including behavior-introducing PR) and confirmed that it now picks up new data when replacing an event file entirely rather than appending to it, writes the appropriate log messages, disables RustBoard, etc.
Cc: #349.