Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time to use build from setuptools instead of distutils? #11194

Open
abravalheri opened this issue Apr 22, 2024 · 0 comments
Open

Time to use build from setuptools instead of distutils? #11194

abravalheri opened this issue Apr 22, 2024 · 0 comments
Assignees
Labels
models:research models that come under research directory

Comments

@abravalheri
Copy link

abravalheri commented Apr 22, 2024

The following feature in setuptools has been deprecated for almost 2 years and is about to be removed:

https://github.com/pypa/setuptools/blob/1ed759173983656734c3606e9c97a348895e5e0c/setuptools/command/build.py#L13-L27

It might be a good idea to import build directly from setuptools for the following code:

class _BuildCommand(build.build):
sub_commands = [
('bazel_build', lambda self: True),
] + build.build.sub_commands

(build is available directly from setuptools, starting on version v62.4.0)

@laxmareddyp laxmareddyp added the models:research models that come under research directory label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models:research models that come under research directory
Projects
None yet
Development

No branches or pull requests

2 participants