Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slick-carousel/slick.scss is imported twice #352

Closed
shobee opened this issue May 25, 2016 · 3 comments
Closed

slick-carousel/slick.scss is imported twice #352

shobee opened this issue May 25, 2016 · 3 comments

Comments

@shobee
Copy link

shobee commented May 25, 2016

Hi there,

rails-assets-slick-carousel-1.6.0/app/assets/stylesheets/slick-carousel.scss looks like this:

@import 'slick-carousel/slick.scss';
@import 'slick-carousel/slick.scss';

Not sure if this is the right place to address this and where this can be fixed?

@hut8
Copy link
Member

hut8 commented May 25, 2016

Interesting. I will look into this tomorrow; I have some pretty urgent other stuff right now. Is this causing issues?

@hut8
Copy link
Member

hut8 commented May 25, 2016

OK more information 😄

Reading the bower spec, specifically the history behind this pull request, I think that the slick-carousel folks have a bug in their bower.json. Specifically, I don't think they should be including slick.css in main. On a totally unrelated note, because of bower/bower#2232, they don't need to be including
the version tag either if you're planning on making a PR to that repo 😏

https://github.com/twbs/bootstrap/pull/16359/files -- looks like in 2015, Bootstrap removed the regular .css file and just includes .less in main. So I think that slick-carousel should follow suit. What are your thoughts on this?

@shobee
Copy link
Author

shobee commented May 26, 2016

Thanks for diving into this so quickly! I think it is obviously which way to go. So I am going to close this issue here and open a new at the slick-carousel repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants