Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespacing introduced package duplication #318

Open
xire28 opened this issue Apr 1, 2016 · 4 comments
Open

Namespacing introduced package duplication #318

xire28 opened this issue Apr 1, 2016 · 4 comments

Comments

@xire28
Copy link

xire28 commented Apr 1, 2016

There seems to be two naming conventions for components:

  • The one used for dependencies without namespace :
    rails-assets-BOWER_PACKAGE_NAME
  • The normal one with namespace :
    rails-assets-USERNAME--BOWER_PACKAGE_NAME

So if you add a package as a dependency and then add it on his own, will get two separated package for one repository:

Using a real example, I currently have the two following gems:

gem 'rails-assets-behavior-google-map-marker-ujs'
gem 'rails-assets-xire28--behavior-google-map-marker-ujs'
@jnylen
Copy link

jnylen commented Apr 7, 2016

@joshjordan and @hut8, wouldn't this kinda help #44 ?

@joshjordan
Copy link
Member

@jnylen these are not forks - the two gems refer to the same repo.

@xire28 I see the issue, but do not understand the sequence of events that you believe caused it. Can you show me an example that will produce this state, or tell me the steps to reproduce with my own package?

@xire28
Copy link
Author

xire28 commented Apr 7, 2016

Reproducting the issue is simple, you only need two packages (A and B) and have A be a dependency of B.

Then if you add the B package using rails-assets, the following gems are created:
rails-assets-USERNAME--B
rails-assets-A

After if you add the A package on his own, this gem is created:
rails-assets-USERNAME--A

In the end, you end up with three gems with a duplication for the package A:
rails-assets-USERNAME--B
rails-assets-USERNAME--A
rails-assets-A

@joshjordan
Copy link
Member

That seems simple to address. Thanks!

On Thu, Apr 7, 2016 at 9:26 AM xire28 notifications@github.com wrote:

Reproducting the issue is simple, you only need two packages (A and B) and
have A be a dependency of B.

Then if you add the B package using rails-assets, the following gems are
created:
rails-assets-USERNAME--B
rails-assets-A

After if you add the A package on his own, this gem is created:
rails-assets-USERNAME--A

In the end, you end up with three gems with a duplication for the package
A:
rails-assets-USERNAME--B
rails-assets-USERNAME--A
rails-assets-A


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#318 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants