build: fix the image to work with golangci-lint #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #195 I updated the Go version, and also swapped from Debian to Alpine for the base image. This was OK for the build, but it turns out we also use the same image to run golangci-lint. That action uses a binary for a different architecture, which fails on this image. So: - Keep the Go version, but revert the base image. - Split image layers to make rebuilds faster. - Add version labels as arguments. - Add some documentation to the workflow configs.
creachadair
force-pushed
the
mjf/build-image-2
branch
from
d92769c
to
fb73650
Compare
creachadair
force-pushed
the
mjf/build-image-2
branch
from
fb73650
to
fa1c59c
Compare
creachadair
requested review from
alexanderbez,
cmwaters,
tac0turtle,
tessr,
tychoish and
williambanfield
as code owners
tychoish
approved these changes
Nov 8, 2021
Merged
creachadair
pushed a commit
that referenced
this pull request
Nov 9, 2021
In #195 I updated the Go version, and also swapped from Debian to Alpine for the base image. This was OK for the build, but it turns out we also use the same image to run golangci-lint. That action uses a binary for a different architecture, which fails on this image. So: - Keep the Go version, but revert the base image. - Split image layers to make rebuilds faster. - Add version labels as arguments. - Add some documentation to the workflow configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: Because the tests use the existing image, and we do not have local credentials to manually push a new one, this PR temporarily disables the test cases to get a new image built. I will revert that change after the image updates.
In #195 I updated the Go version, and also swapped from Debian to Alpine for
the base image. This was OK for the build, but it turns out we also use the
same image to run golangci-lint. That action uses a binary for a different
architecture, which fails on this image.
So: