Retract the accidentally-released v0.6.5. #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
requested review from
alexanderbez,
cmwaters,
tac0turtle,
tessr,
tychoish and
williambanfield
as code owners
creachadair
force-pushed
the
mjf/retract-broken
branch
from
adaea3c
to
22439e3
Compare
Update the go.mod file to version 1.16, to allow the retract syntax.
creachadair
force-pushed
the
mjf/retract-broken
branch
from
22439e3
to
041607a
Compare
tac0turtle
reviewed
Nov 8, 2021
| @@ -16,3 +16,6 @@ require ( | |||
| go.etcd.io/bbolt v1.3.6 | |||
| google.golang.org/grpc v1.38.0 | |||
| ) | |||
|
|
|||
| // Breaking changes were released with the wrong tag (use v0.6.4). | |||
| retract v0.6.5 | |||
There was a problem hiding this comment.
woah didnt know this was possible
There was a problem hiding this comment.
It's a new feature with Go 1.16, but it is really helpful for cases like this. 🙂
tac0turtle
approved these changes
Nov 8, 2021
creachadair
pushed a commit
that referenced
this pull request
Nov 9, 2021
Update the go.mod file to version 1.16, to allow the retract syntax. Mark v0.6.5 as retracted, since it contains large breaking package structure changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the go.mod file to version 1.16, to allow the retract syntax.
Requires #195 (or equivalent) to be merged first.In addition to this, I think we should move this release into a separate branch, revert the changes from master, and cut a v0.6.6 as a successor to v0.6.4 so that we can still have a viable mainline for bug fixes and such.