Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrepareProposal/ProcessProposal: Compare types.proto in feature/abci++ppp and v0.36.x #9221

Closed
3 tasks
sergio-mena opened this issue Aug 11, 2022 · 1 comment
Closed
3 tasks

PrepareProposal/ProcessProposal: Compare types.proto in feature/abci++ppp and v0.36.x #9221

sergio-mena opened this issue Aug 11, 2022 · 1 comment
Assignees
@sergio-mena

Comments

@sergio-mena
Copy link
Contributor

sergio-mena commented Aug 11, 2022 •
edited

[sub-issue of #9053]

Current discrepancies (as of 2022-08-11):

  • PrepareProposal/ProcessProposal related:
  • ConsensusParams
  • BlockParams
  • ABCI version field

Other unrelated discrepancies - to decide if we want them on v0.37.x

  • Fields of EventAttribute from bytes to string
  • Simplification of ResponseCheckTx
@sergio-mena sergio-mena changed the title Compare the status of abci's types.proto in feature/abci++ppp and v0.36.x and make sure no changes are related to PrepareProposal/ProcessProposal PrepareProposal/ProcessProposal: Compare types.proto in feature/abci++ppp and v0.36.x Aug 11, 2022
@sergio-mena sergio-mena self-assigned this Aug 11, 2022
This was referenced Aug 11, 2022
Closed
Merged
@sergio-mena
Copy link
Contributor Author

Closed by #9224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergio-mena sergio-mena

Labels
None yet
Projects
Tendermint
Status: Done/Merged
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sergio-mena