Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation of Mockery v2 in CI #8693

Closed
creachadair opened this issue Jun 3, 2022 · 2 comments · Fixed by #8697
Closed

Fix installation of Mockery v2 in CI #8693

creachadair opened this issue Jun 3, 2022 · 2 comments · Fixed by #8697
Assignees
@creachadair

Comments

@creachadair
Copy link
Contributor

creachadair commented Jun 3, 2022 •
edited

Per the logs:

03 Jun 22 07:37 PDT WRN !!! DEPRECATION NOTICE !!! dry-run=false version=v2.12.3
03 Jun 22 07:37 PDT WRN Using go install to download mockery will likely break after June 1, 2022. Please view PR #456 for details. dry-run=false version=v2.12.3

This is currently making our CI checks fail.

The PR mentioned in the log is vektra/mockery#456
@creachadair creachadair self-assigned this Jun 3, 2022
@creachadair
Copy link
Contributor Author

creachadair commented Jun 3, 2022 •
edited

For various essentially unimportant reasons the tool doesn't want to support go install (and hence go run which is how we use it), so we will need to use one of the other installation methods. The rationalizations for it aren't interesting enough to quibble about.

@creachadair
Copy link
Contributor Author

The above isn't quite correct: It's not actually failing the jobs (yet), there's another error causing the actual failure.

@creachadair creachadair mentioned this issue Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@creachadair creachadair

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update how Mockery mocks are checked for currency. tendermint/tendermint
1 participant
@creachadair