New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add upgrading info about node service #7241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychoish
requested review from
cmwaters,
creachadair,
ebuchman and
williambanfield
as code owners
November 4, 2021 12:05
tychoish
changed the title
Please add a description of the changes that this PR introduces and the files that are the most critical to review.
docs: add upgrading info about node service
Nov 4, 2021
cmwaters
reviewed
Nov 4, 2021
Also I'm wondering if this change should be targeting master and then get backported to 0.35 |
tychoish
force-pushed
the
rpc-upgrading
branch
from
November 4, 2021 13:16
d885eba
to
9d5d0a9
Compare
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
cmwaters
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
* docs: add info about RPC local to upgrading docs * Apply suggestions from code review Co-authored-by: Callum Waters <cmwaters19@gmail.com> * cleanup codeblock Co-authored-by: Callum Waters <cmwaters19@gmail.com> (cherry picked from commit 797541e)
cmwaters
pushed a commit
that referenced
this pull request
Nov 4, 2021
tychoish
added a commit
to tychoish/tendermint
that referenced
this pull request
Nov 19, 2021
* docs: add info about RPC local to upgrading docs * Apply suggestions from code review Co-authored-by: Callum Waters <cmwaters19@gmail.com> * cleanup codeblock Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.