Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pex: avoid starting reactor twice #7239

Merged
merged 2 commits into from Nov 4, 2021
Merged

pex: avoid starting reactor twice #7239

merged 2 commits into from Nov 4, 2021

Conversation

tychoish
Copy link
Contributor

@tychoish tychoish commented Nov 4, 2021

This fixes an issue that lead to some e2e test failures.

cmwaters
cmwaters approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This switch / router stuff has caused a lot of confusion. I think there's some linting problems that needs fixing but other than that this looks good

@tychoish tychoish added the S:automerge Automatically merge PR when requirements pass label Nov 4, 2021
@tychoish tychoish merged commit d59565d into tendermint:v0.35.x Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@creachadair creachadair Awaiting requested review from creachadair

@ebuchman ebuchman Awaiting requested review from ebuchman

@williambanfield williambanfield Awaiting requested review from williambanfield

Assignees
No one assigned
Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tychoish @cmwaters