Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p2p/switch.Broadcast impl #7

Closed
jaekwon opened this issue Nov 6, 2014 · 0 comments
Closed

Fix p2p/switch.Broadcast impl #7

jaekwon opened this issue Nov 6, 2014 · 0 comments
Labels
T:bug Type Bug (Confirmed)

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Nov 6, 2014

Split into Broadcast() and BroadcastTry().
Broadcast() and Send() should time out. **
Errors/failures are returned as a slice.

Adjust the buffer sizes for each channel appropriately, especially increase the StateCh buffer size since it's the most important. HasVoteMessage shouldn't block NewRoundStep/Commit messages.

** think harder

@jaekwon jaekwon added T:bug Type Bug (Confirmed) enhancement labels Nov 6, 2014
@jaekwon jaekwon added this to the Launch milestone Nov 6, 2014
ebuchman added a commit that referenced this issue Mar 18, 2015
ebuchman added a commit that referenced this issue Mar 18, 2015
ebuchman added a commit that referenced this issue Mar 19, 2015
ebuchman added a commit that referenced this issue Mar 31, 2015
state: fix GetStorage on blockcache with unknown account
ebuchman pushed a commit that referenced this issue Jun 20, 2018
ebuchman added a commit that referenced this issue Jun 20, 2018
EventSwitch is an interface
ebuchman added a commit that referenced this issue Jun 20, 2018
ebuchman added a commit that referenced this issue Jun 20, 2018
zramsay pushed a commit that referenced this issue Jul 10, 2018
[tm-monitor] extract lib to monitor/ dir
melekes added a commit that referenced this issue Jun 1, 2020
Closes #4837

- `/block_results`

  before:

  failed to update light client to 7: failed to obtain the header #7: signed header not found

  after:

  We can't return the latest block results because we won't be able to
  prove them. Return the results for the previous block instead.

- /block_results?height=X`

  no changes
melekes added a commit that referenced this issue Jun 2, 2020
Closes #4837

- `/block_results`

  before:

  failed to update light client to 7: failed to obtain the header #7: signed header not found

  after:

  We can't return the latest block results because we won't be able to
  prove them. Return the results for the previous block instead.

- /block_results?height=X`

  no changes
QuantumExplorer pushed a commit to QuantumExplorer/tendermint that referenced this issue Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:bug Type Bug (Confirmed)
Projects
None yet
Development

No branches or pull requests

2 participants