Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abci: change client to use multi-reader mutexes #6306

Merged
merged 8 commits into from Apr 3, 2021
Merged

abci: change client to use multi-reader mutexes #6306

merged 8 commits into from Apr 3, 2021

Conversation

tychoish
Copy link
Contributor

@tychoish tychoish commented Apr 1, 2021

No description provided.

@tychoish tychoish changed the title ninor: change abci client to use multi-reader mutexes minor: change abci client to use multi-reader mutexes Apr 1, 2021
alexanderbez
alexanderbez reviewed Apr 1, 2021
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only want to make Info and Query calls read-locked. Everything else should stay write-locked if I'm not mistaken?

abci/client/grpc_client.go Outdated Show resolved Hide resolved
@tychoish
Copy link
Contributor Author

tychoish commented Apr 1, 2021

Everything else should stay write-locked if I'm not mistaken?

Is there a reason for leaving calls that don't modify the client structs under write-locks?

@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited

Codecov Report

Merging #6306 (cda1d9d) into master (19393f0) will increase coverage by 0.07%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #6306      +/-   ##
==========================================
+ Coverage   60.79%   60.86%   +0.07%     
==========================================
  Files         282      282              
  Lines       26750    26759       +9     
==========================================
+ Hits        16262    16288      +26     
+ Misses       8796     8781      -15     
+ Partials     1692     1690       -2
Impacted Files Coverage Δ
abci/client/client.go 32.35% <0.00%> (ø)
abci/client/grpc_client.go 0.00% <0.00%> (ø)
abci/client/local_client.go 0.00% <0.00%> (ø)
cmd/tendermint/commands/init.go 3.27% <0.00%> (-0.43%) ⬇️
cmd/tendermint/commands/testnet.go 22.36% <0.00%> (+0.14%) ⬆️
config/config.go 74.69% <0.00%> (-1.18%) ⬇️
proxy/client.go 23.07% <0.00%> (ø)
state/indexer/block/kv/kv.go 50.48% <0.00%> (ø)
abci/client/socket_client.go 38.54% <66.66%> (ø)
config/toml.go 59.09% <100.00%> (-1.78%) ⬇️
... and 10 more

@tychoish tychoish changed the title minor: change abci client to use multi-reader mutexes abci: change client to use multi-reader mutexes Apr 1, 2021
alexanderbez
alexanderbez suggested changes Apr 1, 2021
View reviewed changes
abci/client/grpc_client.go Outdated Show resolved Hide resolved
abci/client/local_client.go Outdated Show resolved Hide resolved
@tychoish tychoish merged commit 1c4dbe3 into tendermint:master Apr 3, 2021
tychoish added a commit to tychoish/tendermint that referenced this pull request Apr 5, 2021
@tychoish
abci: change client to use multi-reader mutexes (tendermint#6306)
094e175
This was referenced Aug 30, 2021
Closed
Merged
@tac0turtle
Copy link
Contributor

@Mergifyio backport v0.34.x

@mergify mergify bot mentioned this pull request Aug 30, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2021

Command backport v0.34.x: success

Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 30, 2021
@tychoish
abci: change client to use multi-reader mutexes (#6306)
279f806 
(cherry picked from commit 1c4dbe3)

# Conflicts:
#	abci/client/local_client.go
#	consensus/byzantine_test.go
tychoish pushed a commit that referenced this pull request Aug 30, 2021
@mergify
abci: change client to use multi-reader mutexes (backport #6306) (#6873)
e0c6199
tychoish added a commit to tychoish/tendermint that referenced this pull request Oct 12, 2021
@tychoish
Revert "abci: change client to use multi-reader mutexes (tendermint#6306
2684c61 
)"

This reverts commit 1c4dbe3.
tychoish added a commit that referenced this pull request Oct 12, 2021
@tychoish
Revert "abci: change client to use multi-reader mutexes (#6306)" (#7106)
34a3fcd 
This reverts commit 1c4dbe3.
mergify bot pushed a commit that referenced this pull request Oct 12, 2021
@tychoish
Revert "abci: change client to use multi-reader mutexes (#6306)" (#7106)
b0f877e 
This reverts commit 1c4dbe3.

(cherry picked from commit 34a3fcd)

# Conflicts:
#	abci/client/creators.go
#	abci/client/local_client.go
#	consensus/common_test.go
#	internal/consensus/byzantine_test.go
#	internal/consensus/reactor_test.go
mergify bot pushed a commit that referenced this pull request Oct 12, 2021
@tychoish
Revert "abci: change client to use multi-reader mutexes (#6306)" (#7106)
e2b9c0e 
This reverts commit 1c4dbe3.

(cherry picked from commit 34a3fcd)
cmwaters pushed a commit that referenced this pull request Oct 12, 2021
@mergify
Revert "abci: change client to use multi-reader mutexes (#6306)" (bac…
a82cb7d 
…kport #7106) (#7109)
tychoish pushed a commit that referenced this pull request Oct 12, 2021
@mergify
Revert "abci: change client to use multi-reader mutexes (#6306)" (bac…
b7fe214 
…kport #7106) (#7110)

* Revert "abci: change client to use multi-reader mutexes (#6306)" (#7106)

This reverts commit 1c4dbe3.

(cherry picked from commit 34a3fcd)
iammadab referenced this pull request in dashpay/tenderdash Oct 13, 2021
@mergify @iammadab
abci: change client to use multi-reader mutexes (backport #6306) (#6873)
1f4b11a 
(cherry picked from commit e0c6199)
tychoish added a commit to tychoish/tendermint that referenced this pull request Oct 13, 2021
@tychoish
Revert "abci: change client to use multi-reader mutexes (tendermint#6306
1ba713c 
)" (tendermint#7106)

This reverts commit 1c4dbe3.
yun-yeo added a commit to terra-money/tendermint that referenced this pull request Dec 23, 2021
@yun-yeo
Revert "Revert "abci: change client to use multi-reader mutexes (tend…
a8a273b 
…ermint#6306)" (backport tendermint#7106) (tendermint#7109)"

This reverts commit a82cb7d.
@cmwaters cmwaters mentioned this pull request Feb 22, 2022
Merged
This was referenced Apr 22, 2022
Merged
Merged
Cashmaney pushed a commit to scrtlabs/tendermint that referenced this pull request Nov 9, 2022
@mergify @Cashmaney
Revert revert abci: change client to use multi-reader mutexes (backport
bae62a7 
tendermint#6306) (tendermint#6873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@tessr tessr Awaiting requested review from tessr

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tychoish @tac0turtle @alexanderbez