Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Warn when runtime can't shutdown due left over NativeConnection #1413

Open
mjameswh opened this issue May 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mjameswh
Copy link
Contributor

mjameswh commented May 7, 2024

Describe the solution you'd like

By API contract, the user is responsible to close() NativeConnection objects they created explicitly (implicitly created connections are closed when its owner Worker is closed).

It is however too easy to forget doing so, and be left wondering why the process isn't completing as expected. With little work, we could emit warn messages when a NativeConnection is left opened for a few seconds after completion of the last associated Worker.

@mjameswh mjameswh added the enhancement New feature or request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant