Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Handle possibility of update-before-start #462

Open
Sushisource opened this issue Jan 12, 2024 · 2 comments
Open

[Bug] Handle possibility of update-before-start #462

Sushisource opened this issue Jan 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Sushisource
Copy link
Member

Describe the bug

Because of the fact that we re-order updates to come before other things a-la signals in Core, it's currently possible to handle an update before running the first bit of workflow code if an update comes in same task as start workflow.

We'll likely need to buffer things as we do in other SDKs (in lieu of making some other choice)

Minimal Reproduction

See the test_workflow_update_handlers_unhappy test and discussion here

Environment/Versions

  • OS and processor: [e.g. M1 Mac, x86 Windows, Linux]
  • Temporal Version: [e.g. 1.14.0?] and/or SDK version
  • Are you using Docker or Kubernetes or building Temporal from source?

Additional context

@Sushisource Sushisource added the bug Something isn't working label Jan 12, 2024
@cretz
Copy link
Member

cretz commented Jan 12, 2024

Also, we need to stop reordering of activation jobs inside of Python. Right now this moves signals first and does not account for updates. But we need to make very sure that the Core ordering matches what is already happening (besides update).

@cretz
Copy link
Member

cretz commented Jan 12, 2024

.NET equivalent: temporalio/sdk-dotnet#176. We need to make sure we have a test that does a start then update then starts a worker and confirms behavior with dynamically registered handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants