Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] API key client option #426

Open
5 of 8 tasks
cretz opened this issue Feb 27, 2024 · 2 comments
Open
5 of 8 tasks

[Feature Request] API key client option #426

cretz opened this issue Feb 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Feb 27, 2024

Describe the solution you'd like

Every place that creates a client (nay a connection) should have an option to accept an API key which becomes the Authorization header of Bearer <api-key>. This is commonly used in self-hosted setups and will become common for cloud.

Client places:

Thought was given to whether this should be lang only or core, but it became clear that "rpc metadata" (aka gRPC metadata aka headers) should remain separate from this setting all the way until headers are actually applied because people copy this client config in other places and it shouldn't just be a shallow alias for setting RPC metadata at that level.

@tlalfano
Copy link

Do we need to add PHP to the list here? @cretz

@cretz
Copy link
Member Author

cretz commented Mar 26, 2024

@tlalfano - yes, I just added it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants