Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Schedule with memo option not updating memo #433

Closed
4ndypanda opened this issue Jan 30, 2024 · 3 comments
Closed

Updating Schedule with memo option not updating memo #433

4ndypanda opened this issue Jan 30, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@4ndypanda
Copy link

4ndypanda commented Jan 30, 2024

Trying to update Schedule's memo with CLI

Describe the bug

Doing temporal schedule update --schedule-id ... --memo $KEY=$VALUE does not update the memo of the Schedule.

Minimal Reproduction

# Create Schedule
temporal schedule create --schedule-id foo --workflow-type Foo --task-queue default --memo bar=1

# Describe Schedule shows "Memo" with "bar": "1"
temporal schedule describe -schedule-id foo -o json

# Update Schedule
temporal schedule update --schedule-id foo --workflow-type Foo --task-queue default --memo bar=2

# Describe Schedule still shows "Memo" with "bar": "1" instead of "bar": "2"
temporal schedule describe -schedule-id foo -o json

Environment/Versions

Running in Docker with this version

$ temporal -v
temporal version 0.10.7 (server 1.22.2) (ui 2.21.3)

Additional context

Is there also any way to get the memo returned with temporal schedule list? Some SDKs like the Python one returns memo in the list results: https://python.temporal.io/temporalio.client.ScheduleListDescription.html#memo.

@4ndypanda 4ndypanda added the bug Something isn't working label Jan 30, 2024
@dnr
Copy link
Member

dnr commented Jan 31, 2024

Updating search attributes and memos on schedules isn't supported yet. See temporalio/temporal#4858 (that's about search attributes but they're handled very similarly so we'll do memo at the same time)

@dnr dnr added enhancement New feature or request and removed bug Something isn't working labels Jan 31, 2024
@dnr
Copy link
Member

dnr commented Jan 31, 2024

For memo in list results, it's available in the protocol but correct, not exposed in the cli yet. That should be easy to add.

@Sushisource
Copy link
Member

Depends on #459 / could possibly be done there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants