prelude: Add missing feature gate for dispatching::repls import
#776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WaffleLapkin, it seems that everything is ok with this PR. We can merge it and release |
Hirrolot
approved these changes
Nov 25, 2022
WaffleLapkin
requested changes
Nov 27, 2022
| # TODO: prolly move it to a separate step? | ||
| - name: Check with no default features | ||
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: check | ||
| args: --no-default-features |
There was a problem hiding this comment.
I'd prefer if this went in with the CI refactor, but it's fine.
README.md
Outdated
| <img src="./media/teloxide-logo.png" width="250"/> | ||
| <img src="https://github.com/teloxide/teloxide/raw/master/media/teloxide-logo.png" width="250"/> |
There was a problem hiding this comment.
what's the reason for this?...
There was a problem hiding this comment.
No logo here: https://crates.io/crates/teloxide.
There was a problem hiding this comment.
Ah, right, that makes sense. Although this should be changed in dev, I think. Since only there the media change happened (well, ignoring the accidental merge.)
Hirrolot
approved these changes
Nov 28, 2022
WaffleLapkin
force-pushed
the
fix-feature-gate
branch
from
a50872e
to
7a0c70e
Compare
WaffleLapkin
approved these changes
Nov 28, 2022
WaffleLapkin
force-pushed
the
fix-feature-gate
branch
from
7a0c70e
to
02398e3
Compare
Hirrolot
approved these changes
Nov 28, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like I missed another instance of the #770 issue when I worked on #771... 馃檲
This PR fixes a similar issue in the
preludemodule :)