Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing feature gate for dispatching::repls import #771

Merged
merged 2 commits into from Nov 17, 2022

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Nov 17, 2022

Resolves #770

Note that I've opened the PR against master since this is supposed to be a bugfix for the v0.11.1 release. Please let me know if I should rebase it.

Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should be careful with backports, not sure how to do it best. @Hirrolot do we update the version and all the stuff directly in this PR?

@Hirrolot
Copy link
Collaborator

We should approach it in the following way:

  1. Merge this PR to master.
  2. Release v0.11.2 and yank v0.11.1.
  3. Merge master into dev (fingers crossed that the recent crates merging won't conflict with this...)

@Hirrolot
Copy link
Collaborator

Waiting for @WaffleLapkin double-check, and then we can merge it.

@WaffleLapkin WaffleLapkin merged commit c1c71c5 into teloxide:master Nov 17, 2022
Hirrolot added a commit that referenced this pull request Nov 28, 2022
This reverts commit c1c71c5, reversing
changes made to 2c52e2a.
Hirrolot added a commit that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unresolved import dispatching::repls
3 participants