Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.11.1 #757

Merged
merged 3 commits into from Oct 31, 2022
Merged

Release v0.11.1 #757

merged 3 commits into from Oct 31, 2022

Conversation

Hirrolot
Copy link
Collaborator

No description provided.

Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also set the version in the migration guide

@Hirrolot
Copy link
Collaborator Author

But there will be no version v0.11.1 in the migration guide I suppose, since this release is non-breaking.

@WaffleLapkin
Copy link
Member

@Hirrolot then maybe remove the "0.xxx.xxx" section altogether? I think it would be confusing for users to see it...

@Hirrolot
Copy link
Collaborator Author

Well if someone is on v0.10.0 for instance, and they want to upgrade their code, they'll see a useful link. I don't see why it can be misleading.

@WaffleLapkin
Copy link
Member

Because "0.xxx.xxx" is a placeholder meant to be filled with a version, it's a section that is not finished

@Hirrolot
Copy link
Collaborator Author

Ah, I didn't notice it. Yes, I'll fix that.

@Hirrolot
Copy link
Collaborator Author

@WaffleLapkin, I've pushed the fix.

Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I'm wandering if there are places with the crate which we've forgot to update... We really should automatize the release process :/

@Hirrolot Hirrolot merged commit 42fc655 into dev Oct 31, 2022
@Hirrolot Hirrolot deleted the release-v0.11.1 branch October 31, 2022 15:44
WaffleLapkin pushed a commit that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants