New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.11.1 #757
Release v0.11.1 #757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also set the version in the migration guide
But there will be no version v0.11.1 in the migration guide I suppose, since this release is non-breaking. |
@Hirrolot then maybe remove the "0.xxx.xxx" section altogether? I think it would be confusing for users to see it... |
Well if someone is on v0.10.0 for instance, and they want to upgrade their code, they'll see a useful link. I don't see why it can be misleading. |
Because "0.xxx.xxx" is a placeholder meant to be filled with a version, it's a section that is not finished |
Ah, I didn't notice it. Yes, I'll fix that. |
ef54464
to
b97c2c6
Compare
@WaffleLapkin, I've pushed the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I'm wandering if there are places with the crate which we've forgot to update... We really should automatize the release process :/
Release v0.11.1 Former-commit-id: 42fc655
No description provided.