Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabStrip warnings in React.StrictMode #723

Closed
simonssspirit opened this issue Sep 15, 2020 · 11 comments
Closed

TabStrip warnings in React.StrictMode #723

simonssspirit opened this issue Sep 15, 2020 · 11 comments
Assignees
@nstoychev
Labels
Bug Item which indicates that something is not working pkg:Layout
Milestone
4.7.0

Comments

@simonssspirit
Copy link
Contributor

These are the two warnings:

  • Legacy context API has been detected within a strict-mode tree.
  • findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here:

The issue is most probably connected to the animations:

reactstrap/reactstrap#1833
@simonssspirit simonssspirit added Bug Item which indicates that something is not working pkg:Layout labels Sep 15, 2020
@simonssspirit
Copy link
Contributor Author

The same issue is reproduced inside the PanelBar and both seem to be connected.

Raising priority - 1493762

@simonssspirit
Copy link
Contributor Author

Also reported in 1498972.

@simonssspirit
Copy link
Contributor Author

reported again 1512746

@simonssspirit
Copy link
Contributor Author

1523608 - raising priority again.

@simonssspirit
Copy link
Contributor Author

a possible workaround is to disable the animation:

https://www.telerik.com/kendo-react-ui-develop/components/layout/api/PanelBarProps/#toc-animation

@Xizario Xizario added this to the 4.7.0 milestone Jun 25, 2021
@Xizario
Copy link
Contributor

Xizario commented Jun 25, 2021

Fixed in 4.7.0 with the update of the react-transition-group to 4.4.2

@Xizario Xizario closed this as completed Jun 25, 2021
@g-six
Copy link

g-six commented Sep 27, 2021

Still happening on my end.
image

Using version 4.8.0.

The workaround suggested by @simonssspirit worked for me but just a temporary solution. Would need the animation / transition still.

Anything I'm missing? Let me know.

Fixed in 4.7.0 with the update of the react-transition-group to 4.4.2

g-six pushed a commit to g-six/skyrun-2021 that referenced this issue Nov 5, 2021
fix: 🐛 KendoUI spits error on TabStrip component
473a155 
A known issue here: telerik/kendo-react#723.
Workaround was to disable animation as suggested by simonssspirit
g-six pushed a commit to g-six/skyrun-2021 that referenced this issue Nov 5, 2021
Merged in main (pull request #35)
f9b3238 
Sprint 3 Release

* feat: 🎸 install kendo treeview

* Merged feat/AOT-25-create-calendar-page into main
* Merge branch 'main' of bitbucket.org:aot_code/aot_frontend into feat/AOT-122-create-clients-page

* fix: 🐛 KendoUI spits error on TabStrip component

A known issue here: telerik/kendo-react#723.
Workaround was to disable animation as suggested by simonssspirit

* feat: 🎸 updated landing page

* fix: 🐛 street_1 missing

* fix: 🐛 error type needs to be explicit

* fix: 🐛 jest-fetch-mock to mock fetch()

* Merged in feat/AOT-79-landing-page-style-update (pull request #34)

Feat/AOT-79 landing page style update
* chore: 🤖 resolve conflicts from UAT
@filipKovachev
Copy link
Contributor

filipKovachev commented Nov 22, 2021 •
edited by nstoychev

Still reproducible. Reported in 1543598:
https://stackblitz.com/edit/react-spmvaf?file=app/main.jsx

@nstoychev nstoychev reopened this Nov 22, 2021
@MattiaMalandrone
Copy link

Got the problem with Transition in version v4.11.0

@simonssspirit
Copy link
Contributor Author

reported again in 1549308

@nstoychev nstoychev changed the title TabStrip warnings in React.StrickMode TabStrip warnings in React.StrictMode Jan 20, 2022
@nstoychev nstoychev self-assigned this Jan 20, 2022
@nstoychev
Copy link

Fixed in dev channel - v5.0.2-dev.202201241659.

See the following article for obtaining development builds - https://www.telerik.com/kendo-react-ui/components/installation/development-builds/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nstoychev nstoychev

Labels
Bug Item which indicates that something is not working pkg:Layout
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
6 participants
@g-six @Xizario @MattiaMalandrone @simonssspirit @nstoychev @filipKovachev