Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cp & mv should not overwrite recently created files #631

Closed
nfischer opened this issue Dec 20, 2016 · 4 comments · Fixed by DeviaVir/zenbot#2006 or DeviaVir/zenbot#2010 · May be fixed by ASLANtechnology/serverless-api-cicd#2, iliutastoica/strapi-examples#2 or MailOnline/mol-cz-lerna-changelog#1
Closed

feat: cp & mv should not overwrite recently created files #631

nfischer opened this issue Dec 20, 2016 · 4 comments · Fixed by DeviaVir/zenbot#2006 or DeviaVir/zenbot#2010 · May be fixed by ASLANtechnology/serverless-api-cicd#2, iliutastoica/strapi-examples#2 or MailOnline/mol-cz-lerna-changelog#1
Labels
bash compat Compatibility issues with bash or POSIX behavior fix Bug/defect, or a fix for such a problem help wanted low priority
Milestone
v0.7.x

Comments

@nfischer
Copy link
Member

nfischer commented Dec 20, 2016 •
edited

If you have a copy command like:

$ cp file1.txt out/file1.txt destination/

You should get an error that says something like:

cp: will not overwrite just-created ‘destination/file1.txt’ with ‘out/file1.txt’

We're currently silently overwriting files that we created in that same copy command, but should instead provide a warning and refuse to copy the second file.

The behavior should stay the same with -f and -r, but cp does not give the warning with directories or their contents.

$ cp dir1 out/dir1 destination/ # never has this error
$ ls destination/dir1/ # shows the merged contents of both ./dir1/ and out/dir1/

The warning is never present with the -n flag.

This warning should also be presented for the mv command.
@nfischer nfischer added bash compat Compatibility issues with bash or POSIX behavior fix Bug/defect, or a fix for such a problem low priority labels Dec 20, 2016
@nfischer nfischer added this to the v0.7.x milestone Dec 20, 2016
@nfischer nfischer changed the title feat: cp should not overwrite recently created files feat: cp & mv should not overwrite recently created files Jan 9, 2017
@uttpal
Copy link
Contributor

uttpal commented Apr 7, 2017 •
edited

@nfischer I would like to fix this issue.
Just for clarification, the Expected output is:

  1. -f and -r should provide warning and not overwrite the file.
  2. -n flag should not overwrite nor display the warning.

Please correct me if I am wrong.

@nfischer
Copy link
Member Author

@uttpal Help would be very appreciated!

Yes, I believe your understanding is correct. If in doubt, you can always try out GNU cp/mv on a Linux system.

uttpal added a commit to uttpal/shelljs that referenced this issue Apr 11, 2017
@uttpal
cp: add error to not overwrite recently created files shelljs#631
7f1b998
uttpal added a commit to uttpal/shelljs that referenced this issue Apr 11, 2017
@uttpal
cp: add tests for errors not overwrite recently created files shelljs…
49ce086 
…#631
uttpal added a commit to uttpal/shelljs that referenced this issue Apr 11, 2017
@uttpal
mv: show error when overwriting recently created file shelljs#631
fe8f43d
uttpal added a commit to uttpal/shelljs that referenced this issue Apr 11, 2017
@uttpal
mv: add tests for error on recently created files shelljs#631
8f94027
@uttpal uttpal mentioned this issue Apr 11, 2017
Merged
@uttpal
Copy link
Contributor

uttpal commented Apr 14, 2017

@nfischer
In the case of a directory, cp is overwriting recently created files with the latest one.

cp -R dir1 dir2/dir1 dir3/dir1 dest/
cat dest/dir1/file1 > in dir3

@nfischer
Copy link
Member Author

In the case of a directory, cp is overwriting recently created files with the latest one.

You're right, I was mistaken. Thanks for double checking

uttpal added a commit to uttpal/shelljs that referenced this issue Apr 15, 2017
@uttpal
mv: test remove unnecessary steps shelljs#631
0495354
nfischer pushed a commit that referenced this issue Apr 15, 2017
@uttpal @nfischer
Fix #631 throw error when overwriting recently created file (#702)
bbe521b 
* cp: add error to not overwrite recently created files #631

* cp: add tests for errors not overwrite recently created files #631

* mv: show error when overwriting recently created file #631

* mv: add tests for error on recently created files #631

* mv: test remove unnecessary steps #631
@snyk-bot snyk-bot mentioned this issue Aug 13, 2019
Open
This was referenced Aug 29, 2019
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 19, 2019
Open
@snyk-bot snyk-bot mentioned this issue Nov 29, 2019
Open
@snyk-bot snyk-bot mentioned this issue Dec 18, 2019
Open
@snyk-bot snyk-bot mentioned this issue Mar 8, 2020
Open
This was referenced Mar 24, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Open
This was referenced Apr 24, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bash compat Compatibility issues with bash or POSIX behavior fix Bug/defect, or a fix for such a problem help wanted low priority
Projects
None yet
Milestone
v0.7.x
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade shelljs from 0.7.8 to 0.8.3 DeviaVir/zenbot
[Snyk] Upgrade shelljs from 0.7.8 to 0.8.3 DeviaVir/zenbot
[Snyk] Upgrade shelljs from 0.7.8 to 0.8.3 ASLANtechnology/serverless-api-cicd
[Snyk] Upgrade shelljs from 0.7.8 to 0.8.3 iliutastoica/strapi-examples
[Snyk] Upgrade shelljs from 0.7.0 to 0.8.3 MailOnline/mol-cz-lerna-changelog
[Snyk] Upgrade shelljs from 0.3.0 to 0.8.3 ali8889/byteball
[Snyk] Upgrade shelljs from 0.3.0 to 0.8.3 sharksandcupcakes/html-inspector
[Snyk] Upgrade shelljs from 0.7.8 to 0.8.3 BeeTech-global/generator-api-ecma6
[Snyk] Upgrade shelljs from 0.3.0 to 0.8.3 michelvankessel/colored-coins-copay-wallet
[Snyk] Upgrade shelljs from 0.7.8 to 0.8.3 telegraph/api-responder
2 participants
@nfischer @uttpal