TEP-0127-: Larger results using sidecar logs - Always enforce ReservedSidecarName validation #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dSidecarName validation Prior to this, when validating sidecar name, we would only throw a validation error if the user specifies a sidecar with the same name as ReservedSidecarName and if the `featureflag: results-from` is set to `sidecar-logs`. This PR does a validation check regardless of what the `results-from` feature flag is set to. This way, pipelines don't break due to a change in a feature flag.
tekton-robot
added
release-note
dibyom
approved these changes
Dec 15, 2022
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 tasks
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this, when validating sidecar name, we would only throw a validation error if the user specifies a sidecar with the same name as ReservedSidecarName and if the
featureflag: results-fromis set tosidecar-logs.This PR does a validation check regardless of what the
results-fromfeature flag is set to. This way, pipelines don't break due to a change in a feature flag.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind feature