feat: add new error type for param validation #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1566 +/- ##
=======================================
Coverage 80.45% 80.46%
=======================================
Files 92 92
Lines 4692 4699 +7
Branches 871 871
=======================================
+ Hits 3775 3781 +6
- Misses 644 645 +1
Partials 273 273
|
MichaelSun90
changed the title
|
@arthurschreiber , do we need to worry about this new parameter validation error will review some sensitive information that user may insert within their column, since we are expose the parameter values via this error? |
|
Create a new PR for test these error related, then use the test test against this current changes within this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #1557
create a new Error subclass (maybe called ParameterValidationError), have it inherit from whatever error class we currently use (that might be TypeError, but I'm not sure), and define the additional properties on that.
User will have access to the param name and param value information via both message and error properties.