Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing in keyword arguments leads to a TypeError #70

Open
ysabri opened this issue Jul 19, 2023 · 1 comment
Open

Passing in keyword arguments leads to a TypeError #70

ysabri opened this issue Jul 19, 2023 · 1 comment

Comments

@ysabri
Copy link

ysabri commented Jul 19, 2023

This if statement chain fails when keyword arguments are used for the region and service.

Code looks like this:

AWS4Auth(credentials.access_key, 
                   credentials.secret_key, 
                   region='us-east-1', 
                   service='aoss', 
                   session_token=credentials.token)
@mrapacz
Copy link

mrapacz commented Feb 26, 2024

Just stumbled upon this. I'd expect one of these scenarios to happen:

  1. Minimal effort - I'd expect this TypeError to have a message mentioning that using keyword arguments may cause this package to fail.
  2. Just a little bit more effort - I'd expect the code to handle keyword arguments and compute the l variable based on both args and kwargs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants