Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples from dist package #542

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Remove examples from dist package #542

merged 3 commits into from
Aug 12, 2022

Conversation

cedric-anne
Copy link
Contributor

Examples are embed in dist packages fetched from packagist. In such context, I guess they are not really usefull. Removing them will reduce the package weight from 1.8MB. As package is installed about 35 000 times a day, it will save lots of network trafic and disk space.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
.gitattributes Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-commenter
Copy link

Codecov Report

Merging #542 (d404156) into main (42cd0f9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   72.86%   72.86%           
=======================================
  Files         127      127           
  Lines       23053    23053           
=======================================
  Hits        16798    16798           
  Misses       6255     6255           
Flag Coverage Δ
php-5.3-ubuntu-latest 72.37% <ø> (-0.01%) ⬇️
php-5.4-ubuntu-latest 72.37% <ø> (-0.01%) ⬇️
php-5.5-ubuntu-latest 72.37% <ø> (ø)
php-5.6-ubuntu-latest 72.42% <ø> (ø)
php-7.1-ubuntu-latest 72.80% <ø> (-0.01%) ⬇️
php-7.2-ubuntu-latest 72.68% <ø> (-0.01%) ⬇️
php-7.3-ubuntu-latest 72.68% <ø> (-0.01%) ⬇️
php-7.4-ubuntu-latest 72.68% <ø> (ø)
php-8.0-ubuntu-latest 72.68% <ø> (ø)
php-8.1-ubuntu-latest 72.68% <ø> (ø)
php-nightly-ubuntu-latest 72.68% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42cd0f9...d404156. Read the comment docs.

@nicolaasuni nicolaasuni merged commit b5cbcc2 into tecnickcom:main Aug 12, 2022
@cedric-anne cedric-anne deleted the patch-1 branch September 1, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants